Change in vdsm[ovirt-3.5]: vdsm-tool: is-configured: on el6, we must disable sysv's lib...

ybronhei at redhat.com ybronhei at redhat.com
Mon May 25 22:13:00 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: vdsm-tool: is-configured: on el6, we must disable sysv's libvirtd job
......................................................................


vdsm-tool: is-configured: on el6, we must disable sysv's libvirtd job

In the old libvirt_configure.sh.in script we used to run chkconfig
libvirtd off. It has been missing from the new configurators/libvirt.py
implementation. This patch adds that part which introduced a regression
after first host restarts. On upgrade, we check is-configured for
libvirt module - if sysv still handles the service it will report
NOT_CONFIGURED and reconfigure it to use upstart instead of sysv.

Label: ovirt-3.5-only - initctl hack is relevant only to el6
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1222154
Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d
Signed-off-by: Yaniv Bronhaim <ybronhei at redhat.com>
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/41144
Reviewed-by: Dima Kuznetsov <dkuznets at redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/tool/configurators/libvirt.py
M lib/vdsm/tool/service.py
M tests/toolTests.py
3 files changed, 25 insertions(+), 1 deletion(-)

Approvals:
  Yaniv Bronhaim: Verified
  Jenkins CI: Passed CI tests
  Dima Kuznetsov: Looks good to me, but someone else must approve
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/41144
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Mooli Tayer <mtayer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list