Change in vdsm[master]: Configure libvirt to generate VM's core dumps

apahim at redhat.com apahim at redhat.com
Mon May 25 13:26:23 UTC 2015


Amador Pahim has posted comments on this change.

Change subject: Configure libvirt to generate VM's core dumps
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/41072/3/init/systemd/unlimited-core.conf
File init/systemd/unlimited-core.conf:

Line 1: [Service]
> don't you want to specify that this additional conf file is installed by vd
Done


https://gerrit.ovirt.org/#/c/41072/3/vdsm.spec.in
File vdsm.spec.in:

Line 800: %if 0%{?with_systemd}
Line 801: install -Dm 0644 init/systemd/vdsm-tmpfiles.d.conf \
Line 802:                  %{buildroot}%{_tmpfilesdir}/%{vdsm_name}.conf
Line 803: install -Dm 0644 init/systemd/unlimited-core.conf \
Line 804:                  %{buildroot}%{_sysconfdir}/systemd/system/libvirtd.service.d/unlimited-core.conf
> won't we delete that file during uninstall?
The file is deleted with yum remove. Could you clarify your suggestion?
Line 805: %endif
Line 806: 
Line 807: %if 0%{?rhel}
Line 808: # This is not commonplace, but we want /var/log/core to be a world-writable


-- 
To view, visit https://gerrit.ovirt.org/41072
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I068e1c6386a9076d3e713bc63e7895a5ac458d62
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Amador Pahim <apahim at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list