Change in vdsm[master]: lib: pthread: allow to set system thread names

danken at redhat.com danken at redhat.com
Mon May 25 13:11:36 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: lib: pthread: allow to set system thread names
......................................................................


Patch Set 10:

(3 comments)

https://gerrit.ovirt.org/#/c/41052/10//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-05-25 09:01:01 +0200
Line 6: 
Line 7: lib: pthread: allow to set system thread names
Line 8: 
Line 9: Python allow to set user-friendly names for threads,
allow->allows
Line 10: but the given thread name will be visible only at python level,
Line 11: not at system level.
Line 12: The lack of thread names make hard to follow the resource
Line 13: consumption using system tools (htop, top, ps).


Line 8: 
Line 9: Python allow to set user-friendly names for threads,
Line 10: but the given thread name will be visible only at python level,
Line 11: not at system level.
Line 12: The lack of thread names make hard to follow the resource
make hard -> makes it hard
Line 13: consumption using system tools (htop, top, ps).
Line 14: 
Line 15: This feature was requested for python library, but rejected:
Line 16: http://bugs.python.org/issue15500


Line 12: The lack of thread names make hard to follow the resource
Line 13: consumption using system tools (htop, top, ps).
Line 14: 
Line 15: This feature was requested for python library, but rejected:
Line 16: http://bugs.python.org/issue15500
as far as I understand, it is not yet rejected. It is simply not implemented yet. do i miss something?
Line 17: 
Line 18: VDSM makes large use of threads until upcoming 4.17, and even
Line 19: in 4.17 there is still a fair amount of threads.
Line 20: 


-- 
To view, visit https://gerrit.ovirt.org/41052
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib96bd0471a07449d2a0a0328137e8437aefad901
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list