Change in vdsm[master]: network: check for bridge changes only if unified persistenc...

ibarkan at redhat.com ibarkan at redhat.com
Mon May 25 09:41:48 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: network: check for bridge changes only if unified persistence is used
......................................................................


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41349/4/vdsm/network/api.py
File vdsm/network/api.py:

Line 837:         # Remove edited networks and networks with 'remove' attribute
Line 838:         for network, attrs in networks.items():
Line 839:             if network in _netinfo.networks:
Line 840:                 logger.debug("Removing network %r", network)
Line 841:                 if config.get('vars', 'net_configurator') == 'unified':
I don't understand how this solves the bug. can't Bond.configure() be called from somewhere else? Can you at least prove it by running all functional tests with ifcfg persistence and your patch?
Line 842:                     running_conf = configurator.runningConfig.networks.get(
Line 843:                         network)
Line 844:                     keep_bridge = _should_keep_bridge(
Line 845:                         network_attrs=attrs,


-- 
To view, visit https://gerrit.ovirt.org/41349
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I788e73a1691db5cb49ad24812b9b93c8d47b8927
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list