Change in vdsm[master]: vm: Use blockRebase if blockCopy is not supported

danken at redhat.com danken at redhat.com
Fri May 22 16:25:08 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: Use blockRebase if blockCopy is not supported
......................................................................


vm: Use blockRebase if blockCopy is not supported

blockCopy is available in libvirt 1.2.8, but supported by the qemu
driver only in 1.2.9. The recommended way to check for blockCopy
availability is to try it and handle VIR_ERR_NO_SUPPORT error.

This patch should be reverted when we require libvirt >= 1.2.9.

Change-Id: Ic03474e36d7e073b7e5924cb02f417e12d4ad75e
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40158
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Adam Litke <alitke at redhat.com>
Continuous-Integration: Jenkins CI
---
M vdsm/virt/vm.py
1 file changed, 20 insertions(+), 1 deletion(-)

Approvals:
  Adam Litke: Looks good to me, approved
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40158
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ic03474e36d7e073b7e5924cb02f417e12d4ad75e
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list