Change in vdsm[master]: gluster: use socket.getfqdn instead of 'hostname' binary

osvoboda at redhat.com osvoboda at redhat.com
Fri May 22 16:05:00 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: gluster: use socket.getfqdn instead of 'hostname' binary
......................................................................


Patch Set 3: Verified+1

Build succeeded and

>>> import gluster.cli
>>> gluster.cli._getGlusterHostName()
returns the same string as hostname --fqdn

There is no mention of an exception socket.getfqdn() would raise.

-- 
To view, visit https://gerrit.ovirt.org/37621
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic4b4a0062bedc41bee6528c1d06d707b4f7547e6
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list