Change in vdsm[master]: events: vm status notifications

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri May 22 14:47:46 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: events: vm status notifications
......................................................................


Patch Set 15:

(1 comment)

https://gerrit.ovirt.org/#/c/38937/15/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 390:                               self.guestAgent.diskMappingHash))),
Line 391:             'elapsedTime': str(int(time.time() - self._startTime)),
Line 392:         }
Line 393: 
Line 394:         if value == vmstatus.DOWN:
> There is a bit more information provided by _getExitedVmStats. Do we want t
I would be willing to sacrifice that for clarity. I don't have a strong opinion however...Francesco?

Down is the final event...we always issue Destroy afterwards which is much more heavy...so I'd say clarity wins:)
Line 395:             if 'exitCode' in self.conf:
Line 396:                 stats['exitCode'] = self.conf['exitCode']
Line 397:             if 'exitMessage' in self.conf:
Line 398:                 stats['exitMessage'] = self.conf['exitMessage']


-- 
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 15
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list