Change in vdsm[master]: network: check for bridge changes only if unified persistenc...
danken at redhat.com
danken at redhat.com
Fri May 22 14:16:55 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: network: check for bridge changes only if unified persistence is used
......................................................................
Patch Set 1:
(2 comments)
https://gerrit.ovirt.org/#/c/41349/1//COMMIT_MSG
Commit Message:
Line 7: network: check for bridge changes only if unified persistence is used
Line 8:
Line 9: In _should_keep_bridge we use running configurator to check if we should
Line 10: keep bridge or remove it. Running configurator is available only when we
Line 11: use unified persistence.
Can you specify which tests are broken by this?
Line 12:
Line 13: If we use ifcfg persistence, set keep_bridge always to False.
Line 14:
Line 15: Change-Id: I788e73a1691db5cb49ad24812b9b93c8d47b8927
https://gerrit.ovirt.org/#/c/41349/1/vdsm/network/api.py
File vdsm/network/api.py:
Line 847: 'bridged'],
Line 848: network_running_config=running_conf
Line 849: )
Line 850: else:
Line 851: keep_bridge = False
this means that with ifcfg we cannot change the network vlan when it is used by VMs.
I think that it would be easily fixable with Ido's kerenlConfig. Until that happens, we need a big TODO here.
Line 852:
Line 853: _delNetwork(network, configurator=configurator, force=force,
Line 854: implicitBonding=False, _netinfo=_netinfo,
Line 855: keep_bridge=keep_bridge)
--
To view, visit https://gerrit.ovirt.org/41349
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I788e73a1691db5cb49ad24812b9b93c8d47b8927
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list