Change in vdsm[master]: netinfo: handle never-expiring leases

osvoboda at redhat.com osvoboda at redhat.com
Fri May 22 14:15:16 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: netinfo: handle never-expiring leases
......................................................................


Patch Set 1: Verified+1

The unit test passes with the new case – and dhclient's source code shows there are no other values to be found on "expire" line (function print_time in common/print.c).

Although I was not able (as I comment on the bug) to obtain a lease with "expire never" I think that the unit test proves the fix.

-- 
To view, visit https://gerrit.ovirt.org/41266
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13657a559b7bd5cc32cd830e831acc39550bca3
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list