Change in vdsm[master]: status: adding elapsed time in millis

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri May 22 13:43:22 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: status: adding elapsed time in millis
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40904/5/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 407: 
Line 408:     def _get_elapsed_time_in_millis(self):
Line 409:         return str(
Line 410:             int(round(time.time() * 1000)) -
Line 411:             int(round(self._startTime * 1000))
> _startTime does not solve this issue, as different host may have different 
"messages from a host after migration may look older than messages from the previous host." - actually that doesn't matter, it's per host anyway, so as long as one host reports a monotonic value we're good from monitoring perspective

calling setmetadata every time...well, we do plan to use it for persisting saveState()....but regardless, for the VM uptime I'd rather prefer libvirt enhancement and get it properly
Line 412:         )
Line 413: 
Line 414:     lastStatus = property(_get_lastStatus, _set_lastStatus)
Line 415: 


-- 
To view, visit https://gerrit.ovirt.org/40904
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I38727e0eac7cb29c1dc7c9696568540b6545461c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list