Change in vdsm[master]: virt: Trigger event on guest agent status changes

michal.skrivanek at redhat.com michal.skrivanek at redhat.com
Fri May 22 10:45:18 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: virt: Trigger event on guest agent status changes
......................................................................


Patch Set 3:

(1 comment)

@fromani,vfeenstr thoughts?

https://gerrit.ovirt.org/#/c/41108/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 356: 
Line 357:     def _agent_status_changed(self):
Line 358:         vm_status = self._getVmStatus()
Line 359:         if self.lastStatus != vm_status['status']:
Line 360:             self._send_status_event(vm_status['status'])
so as I was saying in previous patcheset...why don't just 
self._send_status_event(self._getVmStatus()) unconditionaly
Line 361: 
Line 362:     def _get_lastStatus(self):
Line 363:         # note that we don't use _statusLock here. One of the reasons is the
Line 364:         # non-obvious recursive locking in the following flow:


-- 
To view, visit https://gerrit.ovirt.org/41108
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaceca8e42720df50d5eb1e20670b6ed733db8b50
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list