Change in vdsm[master]: vdsm: hook for booting from an ISO image gathered via https

stirabos at redhat.com stirabos at redhat.com
Fri May 22 07:50:48 UTC 2015


Simone Tiraboschi has posted comments on this change.

Change subject: vdsm: hook for booting from an ISO image gathered via https
......................................................................


Patch Set 11:

(4 comments)

https://gerrit.ovirt.org/#/c/41076/11/vdsm_hooks/httpsisoboot/README
File vdsm_hooks/httpsisoboot/README:

Line 5: The hook supports only the https protocols and the host should be able
Line 6: to properly trust the provided URL.
Line 7: 
Line 8: The https source won't work reliably unless you can guarantee a low latency
Line 9: between the VM and the web server. If ever a packet is lost of takes longer
> I'd just say: "In case of latency spikes or packet loss, the guest will see
Done
Line 10: than quite a short period to arrive, the guest will see EIO errors
Line 11: and fail.
Line 12: So it could be adopted with a local web server with plenty of spare capacity
Line 13: and a fast LAN link to RHEV-H, but using it with remotely available ISO


Line 12: So it could be adopted with a local web server with plenty of spare capacity
Line 13: and a fast LAN link to RHEV-H, but using it with remotely available ISO
Line 14: images is not recommended.
Line 15: 
Line 16: The support for plain http has benn removed from qemu-kvm-rhev and qemu-kvm-ev
> typo: been
Done
Line 17:  as a security improvement but it's available upstream.
Line 18: 
Line 19: syntax:
Line 20:     httpsisoboot=https://server/path/to/disk.iso


https://gerrit.ovirt.org/#/c/41076/11/vdsm_hooks/httpsisoboot/before_vm_start.py
File vdsm_hooks/httpsisoboot/before_vm_start.py:

Line 65:                     )
Line 66:                     raise
Line 67: 
Line 68: 
Line 69: def createHttpsIsoElement(domxml, protocol, hostname, port, url_path):
> please rename to
Done
Line 70:     '''
Line 71:     <disk type='network' device='cdrom'>
Line 72:       <driver name='qemu' type='raw'/>
Line 73:       <source protocol="https" name="url_path">


Line 126: 
Line 127:     return disk
Line 128: 
Line 129: 
Line 130: def validateURL(url):
> please rename validate_URL
Done
Line 131:     parsed = urlparse.urlsplit(url)
Line 132:     protocol = parsed.scheme
Line 133:     if protocol != 'https':
Line 134:         hooking.exit_hook(


-- 
To view, visit https://gerrit.ovirt.org/41076
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I22b190b5d3d43cab7bdbfa81bdf0904b2988b2bc
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eldan Shachar <eshachar at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list