Change in vdsm[master]: stomp: preparation of subscribtion class for subscription ma...

danken at redhat.com danken at redhat.com
Thu May 21 16:04:59 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: stomp: preparation of subscribtion class for subscription management
......................................................................


stomp: preparation of subscribtion class for subscription management

So far subscription class was not used but it was designed to handle
unsubscribe in __del__ method which is not the safest idea. We have
decided to prepare it for proper unsubscription logic implement in:
https://gerrit.ovirt.org/#/c/39969


Change-Id: I40cb609432c3d5a7d297e25647a152abdc8e86c5
Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
Reviewed-on: https://gerrit.ovirt.org/41068
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Continuous-Integration: Jenkins CI
---
M lib/yajsonrpc/stomp.py
1 file changed, 25 insertions(+), 15 deletions(-)

Approvals:
  Piotr Kliczewski: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/41068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I40cb609432c3d5a7d297e25647a152abdc8e86c5
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list