Change in vdsm[master]: shell_helper: fix _latest_version as all packages are now no...

osvoboda at redhat.com osvoboda at redhat.com
Thu May 21 15:13:05 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: shell_helper: fix _latest_version as all packages are now noarch
......................................................................


Patch Set 2:

Verified:

1) make rpm of VDSM first
2) source contrib/shell_helper (the one with ~/rpmbuild/RPMS/*/ which doesn't contain my enhancement for foreign packages)
3) run _latest_version (shell_helper's internal function)
   git98aebcc
3) make rpm of e.g. pyroute2 (sources fetched from GitHub)
4) observe that _latest_version fails to detect VDSM
   python-pyroute2-0
5) source contrib/shell_helper with ~/rpmbuild/RPMS/*/vdsm*
6) _latest_version now outputs VDSM's latest build's version again
   git98aebcc

-- 
To view, visit https://gerrit.ovirt.org/41188
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c42c88978eed4edb1d04db3ff676c0c10ac8e8e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list