Change in vdsm[master]: stomp: calling super explicitly

nsoffer at redhat.com nsoffer at redhat.com
Thu May 21 13:04:45 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: stomp: calling super explicitly
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41269/1/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:

Line 75: 
Line 76: class StompError(RuntimeError):
Line 77:     def __init__(self, frame):
Line 78:         self.frame = frame
Line 79:         super(RuntimeError, self).__init__(self.frame.body)
You have two changes hare:
- Keeping frame in the error instance - allows handlers of this error to check the frame
- Using super for calling __init__ - not really needed here but a good practice in general.

Please describe the changes in the commit message. I don't think we should separated these little cleanups.
Line 80: 
Line 81: 
Line 82: class _HeartBeatFrame(object):
Line 83:     def encode(self):


-- 
To view, visit https://gerrit.ovirt.org/41269
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I47d17beaac0b41c3dc0b2de0cf2469d6ff519426
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list