Change in vdsm[master]: vdsm-tool: Add register verb

dougsland at redhat.com dougsland at redhat.com
Wed May 20 16:50:45 UTC 2015


Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-tool: Add register verb
......................................................................


Patch Set 11:

(1 comment)

https://gerrit.ovirt.org/#/c/40966/11/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:

Line 65:         self.engine_fqdn = engine_fqdn
Line 66:         self.logger.debug("Engine FQDN: {fqdn}".format(fqdn=self.engine_fqdn))
Line 67: 
Line 68:         self.engine_url = "https://{e}".format(e=engine_fqdn)
Line 69:         self.logger.debug("Engine URL: {url}".format(url=self.engine_url))
> better move the assignment to after line 72, and this log few lines below, 
Done
Line 70: 
Line 71:         if engine_https_port is None:
Line 72:             self.engine_port = "443"
Line 73:         else:


-- 
To view, visit https://gerrit.ovirt.org/40966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list