Change in vdsm[master]: vm: Unify replication terms

danken at redhat.com danken at redhat.com
Wed May 20 14:20:15 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: vm: Unify replication terms
......................................................................


vm: Unify replication terms

There is no source and destination drives when replication a volume, so
the term "drive" is more correct than "srcDrive". This not only more
correct, but help to streamline the code.

The replica volume info was kept in "dstDiskCopy" which does not reveal
the intention of the code. Now this dict is named "replica".

When setting Drive.diskReplicate, we refer to the dict as "replica"
instead of "dstDisk", which is a leftover from older code.

Change-Id: Idc3ead0616718b1fd6dd877ad98a4fcfce9e5af2
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40023
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Federico Simoncelli <fsimonce at redhat.com>
---
M vdsm/virt/vm.py
1 file changed, 40 insertions(+), 41 deletions(-)

Approvals:
  Nir Soffer: Verified
  Federico Simoncelli: Looks good to me, approved
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40023
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idc3ead0616718b1fd6dd877ad98a4fcfce9e5af2
Gerrit-PatchSet: 16
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list