Change in vdsm[master]: shell_helper: fix _latest_version as all packages are now no...

osvoboda at redhat.com osvoboda at redhat.com
Wed May 20 13:09:57 UTC 2015


Ondřej Svoboda has posted comments on this change.

Change subject: shell_helper: fix _latest_version as all packages are now noarch
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41188/1/contrib/shell_helper
File contrib/shell_helper:

Line 4: 
Line 5: VDSM_DIR=~/code/vdsm
Line 6: 
Line 7: _latest_version() {
Line 8:     ls ~/rpmbuild/RPMS/noarch/ -t -w 1 | head -1 | perl -pe 's|^.*?git|git|' | perl -pe 's|\..*$||'
> can you put "*" here instead? just in case we are compelled to revert the r
Not only that – would you mind if I made it

  ~/rpmbuild/RPMS/*/vdsm*

so the function doesn't clash with other packages?
Line 9: }
Line 10: 
Line 11: _latest_rpms() {
Line 12:     local VERSION=$(_latest_version)


-- 
To view, visit https://gerrit.ovirt.org/41188
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0c42c88978eed4edb1d04db3ff676c0c10ac8e8e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list