Change in vdsm[master]: gluster: detect bricks which are created manually
barumuga at redhat.com
barumuga at redhat.com
Wed May 20 11:26:40 UTC 2015
Bala.FA has posted comments on this change.
Change subject: gluster: detect bricks which are created manually
......................................................................
Patch Set 2:
(1 comment)
https://gerrit.ovirt.org/#/c/39748/2/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 94: for device in devices:
Line 95: deviceInfo = _getDeviceDict(device, _canCreateBrick(device))
Line 96: deviceInfo['brick'] = deviceInfo['mountPoint'] and \
Line 97: deviceInfo['mountPoint'] in brickMountList
Line 98: deviceList.append(deviceInfo)
> It is device only.
If so how do you take care of device name change across reboots?
Line 99: return deviceList
Line 100:
Line 101:
Line 102: def _canCreateBrick(device):
--
To view, visit https://gerrit.ovirt.org/39748
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c1fcafddc42b7bddde51693a15076335d21c9c8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list