Change in vdsm[ovirt-3.5]: disable systemctl intervention when switch to upstart control

danken at redhat.com danken at redhat.com
Wed May 20 10:33:29 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: disable systemctl intervention when switch to upstart control
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41144/1//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-05-20 12:43:54 +0300
Line 4: Commit:     Yaniv Bronhaim <ybronhei at redhat.com>
Line 5: CommitDate: 2015-05-20 12:43:54 +0300
Line 6: 
Line 7: disable systemctl intervention when switch to upstart control
you should disable *sysv*, not systemd's systemctl.

Does your patch keep libvirtd enabled in upstart?

What about the upgrade path? We have ovirt-3.5.z hosts out there, that needs to be fixed.
Line 8: 
Line 9: In old libvirt_configure.sh.in script we used to run chkconfig libvirtd
Line 10: off. it seems to be missing in new configurators/libvirt.py script. This
Line 11: patch add that part which introduced a regression after first host


-- 
To view, visit https://gerrit.ovirt.org/41144
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6326a34cc9e4bee82a427f2543354438205cd11d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list