Change in vdsm[master]: gluster: fix no attribute error

tjeyasin at redhat.com tjeyasin at redhat.com
Wed May 20 06:49:40 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: fix no attribute error
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41056/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 81:         info['uuid'] = device.format.uuid or ''
Line 82:         dev = hasattr(udev, 'get_device') and udev.get_device(
Line 83:             device.sysfsPath) or hasattr(
Line 84:             udev, 'udev_get_device') and udev.udev_get_device(
Line 85:             device.sysfsPath) or {}
> you could make this logic more understandable by
Done
Line 86:         info['fsType'] = device.format.type or dev.get('ID_FS_TYPE', '')
Line 87:     if hasattr(device.format, 'mountpoint'):
Line 88:         info['mountPoint'] = device.format.mountpoint or ''
Line 89:     return info


-- 
To view, visit https://gerrit.ovirt.org/41056
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4ee6f3d62e51c67db12b4859da6508c50e92753
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list