Change in vdsm[master]: events: vm status notifications

mskrivan at redhat.com mskrivan at redhat.com
Wed May 20 06:38:46 UTC 2015


Michal Skrivanek has posted comments on this change.

Change subject: events: vm status notifications
......................................................................


Patch Set 12:

(1 comment)

https://gerrit.ovirt.org/#/c/38937/12/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 392:                 stats['exitCode'] = self.conf['exitCode']
Line 393:             if 'exitMessage' in self.conf:
Line 394:                 stats['exitMessage'] = self.conf['exitMessage']
Line 395:             if 'exitReason' in self.conf:
Line 396:                 stats['exitReason'] = self.conf['exitReason']
> I was suggested to have it that way as a result of long conversation.
suggestion was to return the stats looking like that, seems the function is good enough
Line 397: 
Line 398:         self.cif.notify('|virt|VM_status|' + self.id,
Line 399:                         **{self.id: stats})
Line 400: 


-- 
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list