Change in vdsm[master]: reactor: using single instance
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Tue May 19 22:27:33 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: reactor: using single instance
......................................................................
Patch Set 9:
(3 comments)
https://gerrit.ovirt.org/#/c/40170/9//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2015-04-22 17:02:45 +0200
Line 4: Commit: pkliczewski <piotr.kliczewski at gmail.com>
Line 5: CommitDate: 2015-05-19 15:00:00 +0200
Line 6:
Line 7: reactor: using single instance
> Can you give more context why this change is needed, and how are we going t
Will update the message.
Line 8:
Line 9: Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448
https://gerrit.ovirt.org/#/c/40170/9/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 24
Line 25
Line 26
Line 27
Line 28
> Please import the Reactor here.
Done
Line 54: _glusterEnabled = True
Line 55: except ImportError:
Line 56: _glusterEnabled = False
Line 57:
Line 58: from yajsonrpc.betterAsyncore import Reactor
> Libraries should be imported before vdsm internal modules.
Done
Line 59:
Line 60:
Line 61: class clientIF(object):
Line 62: """
--
To view, visit https://gerrit.ovirt.org/40170
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8f36ec36b91fcc46e1ab46eb92f9739e9e19e448
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list