Change in vdsm[master]: vdsm-tool: Add register verb

dougsland at redhat.com dougsland at redhat.com
Tue May 19 16:49:05 UTC 2015


Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-tool: Add register verb
......................................................................


Patch Set 10: Verified+1

I have verified the patch in 3 ways:

Starting the tool via TUI (patch in the commit msg), using the autoreg (replace for vdsm-config, patch in commit) and manually. All worked and generated the log in /var/log/vdsm/register.log

Real example:

Engine FQDN: engine.localdomain
Engine IP: 192.168.122.166

# vdsm-tool register --engine-fqdn engine.localdomain
Identifying the registration protocol...
Registration procotol selected: service
Host UUID: EC3B64C0-6ADA-4F83-9F89-1960630BE95C
Collecting CA data from Engine...
Calculated fingerprint: 61:95:a7:c1:e8:3a:f0:b3:cc:dd:51:6d:f2:f1:f5:f3:c7:57:67:42
Collecting ssh pub key data...
Registration completed, host is pending approval on Engine: engine.localdomain

######## TEST 2
# vdsm-tool register --engine-fqdn 192.168.122.166
Identifying the registration protocol...
Registration procotol selected: service
Host UUID: EC3B64C0-6ADA-4F83-9F89-1960630BE95C
Collecting CA data from Engine...
Calculated fingerprint: 61:95:a7:c1:e8:3a:f0:b3:cc:dd:51:6d:f2:f1:f5:f3:c7:57:67:42
Collecting ssh pub key data...
Cannot connect to engine. 192.168.122.166 matches the FQDN of Engine?
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/vdsm/tool/register.py", line 482, in main
    reg.download_ssh()
  File "/usr/lib/python2.7/site-packages/vdsm/tool/register.py", line 362, in download_ssh
    res = self._execute_http_request(self.url_ssh_key)
  File "/usr/lib/python2.7/site-packages/vdsm/tool/register.py", line 218, in _execute_http_request
    res = requests.get("{u}".format(u=url), verify=cert_validation)
  File "/usr/lib/python2.7/site-packages/requests/api.py", line 55, in get
    return request('get', url, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/api.py", line 44, in request
    return session.request(method=method, url=url, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 288, in request
    resp = self.send(prep, stream=stream, timeout=timeout, verify=verify, cert=cert, proxies=proxies)
  File "/usr/lib/python2.7/site-packages/requests/sessions.py", line 383, in send
    r = adapter.send(request, **kwargs)
  File "/usr/lib/python2.7/site-packages/requests/adapters.py", line 213, in send
    raise SSLError(e)
SSLError: hostname '192.168.122.166' doesn't match u'engine.localdomain'

########### TEST 3 
# vdsm-tool register --engine-fqdn 192.168.122.166 --check-fqdn false
Identifying the registration protocol...
Registration procotol selected: service
Host UUID: EC3B64C0-6ADA-4F83-9F89-1960630BE95C
Collecting CA data from Engine...
Calculated fingerprint: 61:95:a7:c1:e8:3a:f0:b3:cc:dd:51:6d:f2:f1:f5:f3:c7:57:67:42
Collecting ssh pub key data...
Registration completed, host is pending approval on Engine: 192.168.122.166

######## TEST 4
# vdsm-tool register --engine-fqdn 192.168.122.166 --check-fqdn false --ssh-user root
Identifying the registration protocol...
Registration procotol selected: service
Host UUID: EC3B64C0-6ADA-4F83-9F89-1960630BE95C
Collecting CA data from Engine...
Calculated fingerprint: 61:95:a7:c1:e8:3a:f0:b3:cc:dd:51:6d:f2:f1:f5:f3:c7:57:67:42
Collecting ssh pub key data...
Registration completed, host is pending approval on Engine: 192.168.122.166

-- 
To view, visit https://gerrit.ovirt.org/40966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list