Change in vdsm[master]: Adding unittests for caps.py

danken at redhat.com danken at redhat.com
Tue May 19 15:55:59 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: Adding unittests for caps.py
......................................................................


Patch Set 11: Code-Review-1

(1 comment)

nit about space

https://gerrit.ovirt.org/#/c/41077/11/tests/cpu_map.xml
File tests/cpu_map.xml:

Line 1: <!--  Taken from /usr/share/libvirt/cpu_map.xml
Line 2:       Needed for capsTests.testGetAllCpuModels to have a predictable 
gerrit hates trailing spaces
Line 3:       source of data to test the parsing of the file -->
Line 4: <cpus>
Line 5:   <arch name='x86'>
Line 6:     <!-- vendor definitions -->


-- 
To view, visit https://gerrit.ovirt.org/41077
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list