Change in vdsm[master]: modify safelease executable path

dkuznets at redhat.com dkuznets at redhat.com
Tue May 19 14:38:04 UTC 2015


Dima Kuznetsov has posted comments on this change.

Change subject: modify safelease executable path
......................................................................


Patch Set 3: Code-Review-1

We should not hardcode libexec paths if we plan to ship packages outside fedora derived distros. My Ubuntu Trusty server does not have such path (and I think Debians neither)..

It also makes much sense to move safelease into the $PATH bow. When it was packaged as part of VDSM, and only VDSM used it, it made sense to put it into libexec as it was an executable internal to the other code, but not since it became independently packaged utility, you wouldn't expect anyone who installs it to run it with absolute path from a much less standard location.

-- 
To view, visit https://gerrit.ovirt.org/41024
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ief298fe08e3b737c5c9f404675a15da4b026ca21
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list