Change in vdsm[master]: vdsm-tool: Add register verb

ybronhei at redhat.com ybronhei at redhat.com
Tue May 19 12:40:54 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: vdsm-tool: Add register verb
......................................................................


Patch Set 6:

(2 comments)

https://gerrit.ovirt.org/#/c/40966/6/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:

Line 412:         formatter_class=argparse.RawTextHelpFormatter,
Line 413:         description='Tool to register node to Engine',
Line 414:         epilog='Example of use:\n%(prog)s '
Line 415:                     '--engine-fqdn engine.mydomain'
Line 416:     )
each exposed function should have 

 ''' 
 comment
 ''' 
in first line
Line 417: 
Line 418:     # Needed by vdsm-tool. Otherwise it complains about register
Line 419:     # option doesn't exist
Line 420:     parser.add_argument(


Line 417: 
Line 418:     # Needed by vdsm-tool. Otherwise it complains about register
Line 419:     # option doesn't exist
Line 420:     parser.add_argument(
Line 421:         'register',
> no. vdsm-tool goes over all @exposed functions and add them as arguments to
I missed that you don't pass to ArgumentParser the *args so you get all of them here. you could avoid the restister by parsing args[1:] but as it is is fine
Line 422:     )
Line 423: 
Line 424:     parser.add_argument(
Line 425:         '--node-fqdn',


-- 
To view, visit https://gerrit.ovirt.org/40966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list