Change in vdsm[master]: v2v: Add allocation type for disk conversion

danken at redhat.com danken at redhat.com
Tue May 19 10:27:34 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: v2v: Add allocation type for disk conversion
......................................................................


Patch Set 5: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/40533/5/vdsm/v2v.py
File vdsm/v2v.py:

Line 418:     def _create_command(self):
Line 419:         cmd = [_VIRT_V2V.cmd,
Line 420:                '-ic', self._uri,
Line 421:                '-o', 'vdsm',
Line 422:                '-of', self._vminfo.get('format', 'raw'),
"raw" should better be taken from @VolumeFormat. at RAW
Line 423:                '-oa', self._vminfo.get('allocation', 'sparse')]
Line 424:         cmd.extend(self._generate_disk_parameters())
Line 425:         cmd.extend(['--password-file',
Line 426:                     self._passwd_file,


Line 419:         cmd = [_VIRT_V2V.cmd,
Line 420:                '-ic', self._uri,
Line 421:                '-o', 'vdsm',
Line 422:                '-of', self._vminfo.get('format', 'raw'),
Line 423:                '-oa', self._vminfo.get('allocation', 'sparse')]
@VolumeAllocation. at SPARSE
Line 424:         cmd.extend(self._generate_disk_parameters())
Line 425:         cmd.extend(['--password-file',
Line 426:                     self._passwd_file,
Line 427:                     '--vdsm-vm-uuid',


-- 
To view, visit https://gerrit.ovirt.org/40533
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd3ca2983455adbb51f11957e0ce042b0cfc5ef1
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list