Change in vdsm[master]: RFE: Report downtime for each live migration

shavivi at redhat.com shavivi at redhat.com
Tue May 19 09:57:16 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: RFE: Report downtime for each live migration
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/40103/7/vdsm/rpc/Bridge.py
File vdsm/rpc/Bridge.py:

Line 383:     """
Line 384:     return {'params': ret['params'], 'migrationPort': ret['migrationPort']}
Line 385: 
Line 386: 
Line 387: def VM_getMigrationStatus_Ret(ret):
> its not working other solutions suck as
Also since its a union the key for the 'ret' value is vary:
MigratedStats or MigratingStats it depend on the context - the empty method is the one that works for both ways
Line 388:     """
Line 389:     Return status of the Migration, progress and downtime if available
Line 390:     """
Line 391:     return ret


-- 
To view, visit https://gerrit.ovirt.org/40103
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2ff421c489ef24869502bd80461018f0aca2144d
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list