Change in vdsm[master]: Adding unittests for caps.py

danken at redhat.com danken at redhat.com
Tue May 19 09:15:34 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: Adding unittests for caps.py
......................................................................


Patch Set 9: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/41077/9/tests/capsTests.py
File tests/capsTests.py:

Line 231:                     'SandyBridge': 'Intel', 'kvm64': None}
Line 232:         self.assertEqual(expected, result)
Line 233: 
Line 234:     def testGetAllCpuModels_noArch(self):
Line 235:         fileName = 'cpu_map.xml'
please use

  os.path.join(
     os.path.dirname(os.path.realpath(__file__)),
     'cpu_map.xml'
  )

or something like that
Line 236:         result = caps._getAllCpuModels(capfile=fileName,
Line 237:                                        arch='zzz')
Line 238:         self.assertEqual(dict(), result)
Line 239: 


-- 
To view, visit https://gerrit.ovirt.org/41077
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I86c2203bf245ba209e10b0905ae1090835408201
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list