Change in vdsm[master]: vdsm-tool: Add register verb
ybronhei at redhat.com
ybronhei at redhat.com
Tue May 19 08:42:25 UTC 2015
Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: Add register verb
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/40966/6/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:
Line 417:
Line 418: # Needed by vdsm-tool. Otherwise it complains about register
Line 419: # option doesn't exist
Line 420: parser.add_argument(
Line 421: 'register',
> Hi Yaniv, without this line, I see the line below, is that expected to add
no. vdsm-tool goes over all @exposed functions and add them as arguments to vdsm-tool command. you need to parse the args only after "vdsm-tool", "register"
Line 422: )
Line 423:
Line 424: parser.add_argument(
Line 425: '--node-fqdn',
--
To view, visit https://gerrit.ovirt.org/40966
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list