Change in vdsm[master]: Actually use the NUMA stats thread

msivak at redhat.com msivak at redhat.com
Mon May 18 17:00:30 UTC 2015


Martin Sivák has uploaded a new change for review.

Change subject: Actually use the NUMA stats thread
......................................................................

Actually use the NUMA stats thread

The code from https://gerrit.ovirt.org/#/c/33782/4 is missing
from the 3.5 branch and that causes the NUMA efficiency fix to
not work properly.

Change-Id: Ib9696adfed13c101ad52fd67796f2d141c810404
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=1220113
Signed-off-by: Martin Sivak <mars at montik.net>
---
M vdsm/virt/vm.py
1 file changed, 4 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/75/41075/1

diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index 7ec9afb..1853f60 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -281,7 +281,8 @@
         self.sampleNuma = (
             sampling.AdvancedStatsFunction(
                 self._sampleNuma,
-                config.getint('vars', 'vm_sample_numa_interval'), 1))
+                # Minimum supported window is 2
+                config.getint('vars', 'vm_sample_numa_interval'), 2))
 
         self.addStatsFunction(
             self.highWrite, self.updateVolumes, self.sampleCpu,
@@ -630,7 +631,7 @@
             stats[dName].update(dLatency)
 
     def _getNumaStats(self, stats):
-        vmNumaNodeRuntimeMap = self.sampleNuma.getLastSample()
+        vmNumaNodeRuntimeMap, eInfo, sampleInterval = self.sampleNuma.getStats()
         if vmNumaNodeRuntimeMap:
             stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap
 
@@ -659,11 +660,7 @@
         self._getDiskLatency(stats)
         self._getBalloonStats(stats)
         self._getVmJobs(stats)
-
-        vmNumaNodeRuntimeMap = numaUtils.getVmNumaNodeRuntimeInfo(self._vm)
-        if vmNumaNodeRuntimeMap:
-            stats['vNodeRuntimeInfo'] = vmNumaNodeRuntimeMap
-
+        self._getNumaStats(stats)
         self._getCpuTuneInfo(stats)
         self._getCpuCount(stats)
         self._getUserCpuTuneInfo(stats)


-- 
To view, visit https://gerrit.ovirt.org/41075
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib9696adfed13c101ad52fd67796f2d141c810404
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Sivák <msivak at redhat.com>


More information about the vdsm-patches mailing list