Change in vdsm[master]: stomp: preparation of subscribtion class for subscription ma...

danken at redhat.com danken at redhat.com
Mon May 18 15:19:40 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: stomp: preparation of subscribtion class for subscription management
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41068/1//COMMIT_MSG
Commit Message:

Line 5: CommitDate: 2015-05-18 16:28:04 +0200
Line 6: 
Line 7: stomp: preparation of subscribtion class for subscription management
Line 8: 
Line 9: 
please explain why this is safe. It seems as this patch is not independent - it assume subscribe is explicitly called by something else, instead from __del__.
Line 10: Change-Id: I40cb609432c3d5a7d297e25647a152abdc8e86c5


-- 
To view, visit https://gerrit.ovirt.org/41068
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I40cb609432c3d5a7d297e25647a152abdc8e86c5
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list