Change in vdsm[master]: gluster: fix pyflakes error in mount point verification

danken at redhat.com danken at redhat.com
Mon May 18 11:19:24 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: gluster: fix pyflakes error in mount point verification
......................................................................


Patch Set 1: Code-Review+2

Ok, let's quickly unbreak pyflakes, but we must also fix

ERROR: test_parseStorageDevices (gluster_cli_tests.GlusterCliTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/danken/.rpm/BUILD/vdsm-4.17.0.3/tests/gluster_cli_tests.py", line 1116, in test_parseStorageDevices
    status = parseStorageDevices(glusterTestData.glusterStorageDevData())
  File "/home/danken/.rpm/BUILD/vdsm-4.17.0.3/vdsm/gluster/storagedev.py", line 92, in _parseDevices
    deviceList.append(_getDeviceDict(device, _canCreateBrick(device)))
  File "/home/danken/.rpm/BUILD/vdsm-4.17.0.3/vdsm/gluster/storagedev.py", line 82, in _getDeviceDict
    dev = udev.get_device(device.sysfsPath) or {}
AttributeError: 'TestStorageDev' object has no attribute 'sysfsPath'

-- 
To view, visit https://gerrit.ovirt.org/41046
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ad096e0c8cb470311d9f219e7469b16fd697de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: No


More information about the vdsm-patches mailing list