Change in vdsm[master]: gluster: fix pyflakes error in mount point verification

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon May 18 10:45:38 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: gluster: fix pyflakes error in mount point verification
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/41046/1/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 215: 
Line 216:             blivetEnv.reset()
Line 217:             return blivetEnv.devicetree.getDeviceByName(poolLv.name)
Line 218: 
Line 219:     if os.path.ismount(mountPoint):
> yes, its not for _createThinPool function, its for createBrick function onl
OK, so please make sure to fix the other issue. See my previous comment.
Line 220:         raise ge.GlusterHostStorageMountPointInUseException(mountPoint)
Line 221: 
Line 222:     vgName = "vg-" + brickName
Line 223:     poolName = "pool-" + brickName


-- 
To view, visit https://gerrit.ovirt.org/41046
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ad096e0c8cb470311d9f219e7469b16fd697de
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list