Change in vdsm[master]: gluster: fix fstype unavailable for a formatted device
piotr.kliczewski at gmail.com
piotr.kliczewski at gmail.com
Mon May 18 10:07:50 UTC 2015
Piotr Kliczewski has posted comments on this change.
Change subject: gluster: fix fstype unavailable for a formatted device
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40206/5/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:
Line 78: else:
Line 79: info['model'] = device.type
Line 80: if device.format:
Line 81: info['uuid'] = device.format.uuid or ''
Line 82: dev = udev.get_device(device.sysfsPath) or {}
When running build locally I get:
AttributeError: 'module' object has no attribute 'get_device'
Line 83: info['fsType'] = device.format.type or dev.get('ID_FS_TYPE', '')
Line 84: if hasattr(device.format, 'mountpoint'):
Line 85: info['mountPoint'] = device.format.mountpoint or ''
Line 86: return info
--
To view, visit https://gerrit.ovirt.org/40206
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7c5d3913b61e37c6a4ad31e0348f86cde6152b9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list