Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

nsoffer at redhat.com nsoffer at redhat.com
Mon May 18 10:05:14 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: jsonrpc: Prevent password logging
......................................................................


Patch Set 7:

(1 comment)

https://gerrit.ovirt.org/#/c/40961/7/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:

Line 475:         if mangledMethod in ('Host_getVMList', 'Host_getAllVmStats',
Line 476:                              'Host_getStats', 'StorageDomain_getStats',
Line 477:                              'VM_getStats', 'Host_fenceNode'):
Line 478:             logLevel = logging.TRACE
Line 479:         protected_params = self._protected_args(req.method, req.params)
> naming nit: args and params are the very same thing. so please use the same
I would fix the method -> _protected_params since the request object is using "params"
Line 480:         self.log.log(logLevel, "Calling '%s' in bridge with %s",
Line 481:                      req.method, protected_params)
Line 482: 
Line 483:         try:


-- 
To view, visit https://gerrit.ovirt.org/40961
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34a36a361d2be28343352ae83ceac94b86162a12
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list