Change in vdsm[master]: gluster: raise proper execption if the given mount point is ...

piotr.kliczewski at gmail.com piotr.kliczewski at gmail.com
Mon May 18 10:01:25 UTC 2015


Piotr Kliczewski has posted comments on this change.

Change subject: gluster: raise proper execption if the given mount point is in use.
......................................................................


Patch Set 5:

(1 comment)

https://gerrit.ovirt.org/#/c/40892/5/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 213: 
Line 214:             blivetEnv.reset()
Line 215:             return blivetEnv.devicetree.getDeviceByName(poolLv.name)
Line 216: 
Line 217:     if os.path.ismount(mountPoint):
Indentation is not correct and it breaks vdsm build.
Line 218:         raise ge.GlusterHostStorageMountPointInUseException(
Line 219:             mountPoint, rc, out, err)
Line 220: 
Line 221:     vgName = "vg-" + brickName


-- 
To view, visit https://gerrit.ovirt.org/40892
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12acd2e4bf6a88936af582bb17d50d72cdfb84f
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list