Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging
nsoffer at redhat.com
nsoffer at redhat.com
Mon May 18 08:33:47 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: jsonrpc: Prevent password logging
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/40961/5//COMMIT_MSG
Commit Message:
Line 22: unprotect_passwords replace ProtectedPassword objects with the
Line 23: actual password value.
Line 24:
Line 25: The jsonprc server protect request parameters and response result containing
Line 26: passwords by using protect_passwords method introduced in password module.
The reader may assume that passwords are protected in request parameters and results, while they are not; they are protected only in jsonrpc server logs.
Line 27:
Line 28:
Line 29: Change-Id: I34a36a361d2be28343352ae83ceac94b86162a12
Line 30: Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>
--
To view, visit https://gerrit.ovirt.org/40961
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I34a36a361d2be28343352ae83ceac94b86162a12
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list