Change in vdsm[master]: sampling: make _getInterfaceStats a function

ibarkan at redhat.com ibarkan at redhat.com
Mon May 18 07:36:35 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: sampling: make _getInterfaceStats a function
......................................................................


Patch Set 6: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/40430/6/vdsm/virt/sampling.py
File vdsm/virt/sampling.py:

Line 672:             cpuCoreStats[str(cpuCore)] = coreStat
Line 673:     return cpuCoreStats
Line 674: 
Line 675: 
Line 676: def _get_interfaces_stats(hs0, hs1, interval):
isn't interval 'too much information'? I understand that it was already computed, but it is easy to compute, and opens a window for abusing of this function. I t will also make testing more clumsy.
And while you are here, will you add a unit test ;-) ?
Line 677:     rx = tx = rxDropped = txDropped = 0
Line 678:     stats = {'network': {}}
Line 679:     total_rate = 0
Line 680:     for ifid in hs1.interfaces:


-- 
To view, visit https://gerrit.ovirt.org/40430
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0b5796f3463585794d2696ce73f8357cb0fd1f78
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list