Change in vdsm[ovirt-3.5]: jsonrpc: Prevent password logging

nsoffer at redhat.com nsoffer at redhat.com
Sun May 17 19:27:59 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: jsonrpc: Prevent password logging
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/40961/4//COMMIT_MSG
Commit Message:

Line 23:                         actual password value.
Line 24: 
Line 25: The jsonprc server protect passwords in request parameters, and
Line 26: in response result.  This is safest and simplest way, as we cannot
Line 27: forget to protect a method.
> Use are asking for redundant information. We already have what are the chan
I'm asking to make it easy for the next developer to understand what this patch is trying to do, and how it is different from the original patch.

The current text is misleading: 

    The jsonprc server protect passwords in request parameters, and
    in response result.  This is safest and simplest way, as we cannot
    forget to protect a method.

You protect only the jsonrpc logging parameters/results, not the request parameters passed into the application.
Line 28: 
Line 29: 
Line 30: Change-Id: I34a36a361d2be28343352ae83ceac94b86162a12
Line 31: Signed-off-by: pkliczewski <piotr.kliczewski at gmail.com>


-- 
To view, visit https://gerrit.ovirt.org/40961
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I34a36a361d2be28343352ae83ceac94b86162a12
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list