Change in vdsm[master]: vdsm-tool: Add register verb

dougsland at redhat.com dougsland at redhat.com
Sat May 16 21:40:55 UTC 2015


Douglas Schilling Landgraf has posted comments on this change.

Change subject: vdsm-tool: Add register verb
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/40966/1/lib/vdsm/tool/register.py
File lib/vdsm/tool/register.py:

Line 193:         """
Line 194:         The logging settings
Line 195:         Saving log in: /var/log/vdsm/register.log
Line 196:         """
Line 197:         # Avoid node side effects of logging module not been working
> Completing my answer, so vdsm utils import this module and it affects the r
Okay, I understood the issue. I was using ovirt.node logging handler when importing the persist modules. Setting "my" logging handlers made it work as expected, no unload needed.
Line 198:         logging.shutdown()
Line 199:         reload(logging)
Line 200: 
Line 201:         logging.basicConfig(


-- 
To view, visit https://gerrit.ovirt.org/40966
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica800027beec1e5a20165bb5e1e78baf9283c1da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list