Change in vdsm[master]: ifcfg: extract _ifup and call _ifup_nonblocking when 'async'...

danken at redhat.com danken at redhat.com
Sat May 16 21:18:47 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: ifcfg: extract _ifup and call _ifup_nonblocking when 'async' flag was used
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40478/3/vdsm/network/configurators/ifcfg.py
File vdsm/network/configurators/ifcfg.py:

Line 773:         # contains the error reason.
Line 774:         raise ConfigNetworkError(ERR_FAILED_IFUP, out[-1] if out else '')
Line 775: 
Line 776: 
Line 777: def _ifup_nonblocking(iface_name, async=False):
Could you explain (in the commit message) the motivation of this patch?

The naming of this method is quite confusing: with its default arg, it does a *blocking* ifup
Line 778:     if async:
Line 779:         # wait for dhcp in another thread, so vdsm won't get stuck (BZ#498940)
Line 780:         t = threading.Thread(target=_ifup, name='ifup-waiting-on-dhcp',
Line 781:                              args=(iface_name,))


-- 
To view, visit https://gerrit.ovirt.org/40478
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c40cb09f05a0865b1942448a64fd37b735857f9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list