Change in vdsm[master]: conflib: Introduce the conflib library

ybronhei at redhat.com ybronhei at redhat.com
Fri May 15 15:36:01 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: conflib: Introduce the conflib library
......................................................................


Patch Set 2:

(2 comments)

what's wrong with the current json struct we have in config.py?

https://gerrit.ovirt.org/#/c/40960/2/lib/vdsm/conflib.py
File lib/vdsm/conflib.py:

Line 41:         section.__dict__[self.name] = value
Line 42: 
Line 43:     def load(self, section, parser):
Line 44:         section.__dict__[self.name] = parser.getboolean(section.name,
Line 45:                                                         self.name)
need to define string type as well
Line 46: 
Line 47: 
Line 48: class SectionType(type):
Line 49: 


Line 88: class Config(object):
Line 89: 
Line 90:     __metaclass__ = ConfigType
Line 91: 
Line 92:     def load(self, parser):
I'd specify in a comment that it gets ConfigParser object
Line 93:         for name in parser.sections():
Line 94:             try:
Line 95:                 section = self.__class__.__dict__[name]
Line 96:             except KeyError:


-- 
To view, visit https://gerrit.ovirt.org/40960
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1882274f386852960ab3c785193449ab1367fec8
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list