Change in vdsm[ovirt-3.5]: virt: Do not count time spent on migrationCreate against tim...

ybronhei at redhat.com ybronhei at redhat.com
Fri May 15 15:25:46 UTC 2015


Yaniv Bronhaim has submitted this change and it was merged.

Change subject: virt: Do not count time spent on migrationCreate against timeout
......................................................................


virt: Do not count time spent on migrationCreate against timeout

Currently, the measured time for the source migration timeout includes
the time spent on the destination host. This is bad because the time
spent for some actions during the vm creation can be very expensive and
time consuming.
This patch, excludes the time spent during the destination vm creation
from the measured time.

The change is not expected to introduce regressions on the source, since
even now we would hang on the migrationCreate call.

Change-Id: Iafdaa13136757d455e405328173aa3243bea3995
Bug-Url: https://bugzilla.redhat.com/1221597
Signed-off-by: Vinzenz Feenstra <vfeenstr at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/38397
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Yeela Kaplan <ykaplan at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/40919
Continuous-Integration: Jenkins CI
Reviewed-by: Francesco Romani <fromani at redhat.com>
---
M vdsm/virt/migration.py
1 file changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Jenkins CI: Passed CI tests
  Vinzenz Feenstra: Verified
  Dan Kenigsberg: Looks good to me, approved
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/40919
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iafdaa13136757d455e405328173aa3243bea3995
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org


More information about the vdsm-patches mailing list