Change in vdsm[master]: jsonrpc: events
danken at redhat.com
danken at redhat.com
Fri May 15 10:05:36 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: jsonrpc: events
......................................................................
Patch Set 20:
(2 comments)
https://gerrit.ovirt.org/#/c/38069/20/vdsm/clientIF.py
File vdsm/clientIF.py:
Line 16
Line 17
Line 18
Line 19
Line 20
unhelpful...
https://gerrit.ovirt.org/#/c/38069/20/vdsm/rpc/BindingJsonRpc.py
File vdsm/rpc/BindingJsonRpc.py:
Line 30: log = logging.getLogger('BindingJsonRpc')
Line 31:
Line 32: def __init__(self, bridge):
Line 33: self._server = JsonRpcServer(bridge, _simpleThreadFactory)
Line 34: self._reactor = StompReactor()
Allowing only a single reactor is not really related to having events. Please place it in its own patch.
Line 35: self.startReactor()
Line 36:
Line 37: def add_socket(self, reactor, client_socket):
Line 38: reactor.createListener(client_socket, self._onAccept)
--
To view, visit https://gerrit.ovirt.org/38069
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dima Kuznetsov <dkuznets at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list