Change in vdsm[master]: gluster: set default value for dataalignment and physicalext...

tjeyasin at redhat.com tjeyasin at redhat.com
Fri May 15 09:56:08 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: set default value for dataalignment and physicalextent value
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.ovirt.org/#/c/40890/4/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 148:         return vg
Line 149: 
Line 150:     def _createThinPool(poolName, vg, alignment=0,
Line 151:                         poolMetaDataSize=0, poolDataSize=0):
Line 152:         if not poolDataSize:
> why have u changed the logic here as default alignment is 0?
The default alignment value is now 256 for JBOD and normal disks for pvcreate.
The updated document says that, the thin pool and lv create does not required the adjustment for JBOD or normal disk. The adjustment is needed for RAID devices only.

Can i remove the default value for alignment=0 in this function parameter and specify only as 'alignment' ?
Line 153:             # bz#1180228: blivet doesn't handle percentage-based sizes properly
Line 154:             # Workaround: Till the bz gets fixed, we take only 99% size from vg
Line 155:             pool = LVMThinPoolDevice(poolName, parents=[vg],
Line 156:                                      size=(vg.size * 99 / 100),


-- 
To view, visit https://gerrit.ovirt.org/40890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b7f3104705e5d303f4c0739f15cfd592e84b8e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list