Change in vdsm[master]: gluster: set default value for dataalignment and physicalext...

tjeyasin at redhat.com tjeyasin at redhat.com
Fri May 15 08:46:49 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: set default value for dataalignment and physicalextent value
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.ovirt.org/#/c/40890/3/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 226:         lvmpv = blivet.formats.getFormat(
Line 227:             "lvmpv", device=dev.path,
Line 228:             dataAlignment=blivet.size.Size('%s KiB' % alignment))
Line 229:         blivetEnv.formatDevice(dev, lvmpv)
Line 230:     blivet.partitioning.doPartitioning(blivetEnv)
> You should keep this as separate function like before
Done
Line 231: 
Line 232:     # create a vg using pv device list
Line 233:     vg = LVMVolumeGroupDevice(
Line 234:         vgName, peSize=blivet.size.Size(


Line 233:     vg = LVMVolumeGroupDevice(
Line 234:         vgName, peSize=blivet.size.Size(
Line 235:             '%s KiB' % raidParams.get('stripeSize', 256)),
Line 236:         parents=deviceList)
Line 237:     blivetEnv.createDevice(vg)
> same as above
Done
Line 238:     # The following calculation is based on the redhat storage performance doc
Line 239:     # http://docbuilder.usersys.redhat.com/22522
Line 240:     # /#chap-Configuring_Red_Hat_Storage_for_Enhancing_Performance
Line 241: 


-- 
To view, visit https://gerrit.ovirt.org/40890
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8b7f3104705e5d303f4c0739f15cfd592e84b8e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list