Change in vdsm[master]: gluster: raise proper execption if the given mount point is ...

tjeyasin at redhat.com tjeyasin at redhat.com
Fri May 15 08:44:02 UTC 2015


Timothy Asir has posted comments on this change.

Change subject: gluster: raise proper execption if the given mount point is in use.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/40892/3/vdsm/gluster/storagedev.py
File vdsm/gluster/storagedev.py:

Line 214: 
Line 215:             blivetEnv.reset()
Line 216:             return blivetEnv.devicetree.getDeviceByName(poolLv.name)
Line 217: 
Line 218:     if mount.isMounted(mountPoint):
> doesn't os.path.ismount() work here?
Yes, I will update to use os.path.ismount
Line 219:         raise ge.GlusterHostStorageMountPointInUseException(
Line 220:             mountPoint, rc, out, err)
Line 221: 
Line 222:     vgName = "vg-" + brickName


-- 
To view, visit https://gerrit.ovirt.org/40892
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic12acd2e4bf6a88936af582bb17d50d72cdfb84f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga at redhat.com>
Gerrit-Reviewer: Darshan N <dnarayan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ramesh N <rnachimu at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list