Change in vdsm[master]: ceph: Support ephemeral Libvirt secrets
nsoffer at redhat.com
nsoffer at redhat.com
Thu May 14 18:26:07 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: ceph: Support ephemeral Libvirt secrets
......................................................................
Patch Set 14:
(1 comment)
https://gerrit.ovirt.org/#/c/40712/14/tests/vmSecretTests.py
File tests/vmSecretTests.py:
Line 226: def test_unregister_missing(self):
Line 227: existing_sec = make_secret()
Line 228: secret.register([existing_sec])
Line 229: missing_sec = make_secret()
Line 230: res = secret.unregister([missing_sec["uuid"], existing_sec["uuid"]])
> pep8: line too long...
You mean line 192 - fixed in version 15
Line 231: self.assertEqual(res, response.success())
Line 232: self.assertEqual({}, self.connection.secrets)
Line 233:
Line 234: def test_unregister_libvirt_error(self):
--
To view, visit https://gerrit.ovirt.org/40712
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e9ee33a7447ee07b0c82cf5a80d1f9b470663bb
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: automation at ovirt.org
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list